Fix NPE in MlMemoryAutoscalingDecider #116650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-elastic
added
>bug
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @jan-elastic, I've created a changelog YAML for you. |
jan-elastic
commented
Nov 12, 2024
| MlMemoryAutoscalingCapacity capacity = ensureScaleDown( | ||
| result, | ||
| MlMemoryAutoscalingCapacity.from(context.currentCapacity()).build() | ||
| context.currentCapacity() == null ? null : MlMemoryAutoscalingCapacity.from(context.currentCapacity()).build() |
There was a problem hiding this comment.
context.currentCapacity()can benull, see JavaDoc.MlMemoryAutoscalingCapacity.from(null)gives null pointer exceptionensureScaleDown(..., null) = null
|
Hi @jan-elastic, I've updated the changelog YAML for you. |
jan-elastic
added a commit
that referenced
this pull request
Nov 12, 2024
* Fix NPE in MlMemoryAutoscalingDecider * Update docs/changelog/116650.yaml * Update 116650.yaml * Update docs/changelog/116650.yaml * better fix
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 12, 2024
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
* Fix NPE in MlMemoryAutoscalingDecider * Update docs/changelog/116650.yaml * Update 116650.yaml * Update docs/changelog/116650.yaml * better fix
jan-elastic
added a commit
that referenced
this pull request
Nov 13, 2024
* Fix NPE in MlMemoryAutoscalingDecider * Update docs/changelog/116650.yaml * Update 116650.yaml * Update docs/changelog/116650.yaml * better fix
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 13, 2024
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 14, 2024
* Fix NPE in MlMemoryAutoscalingDecider * Update docs/changelog/116650.yaml * Update 116650.yaml * Update docs/changelog/116650.yaml * better fix
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
* Fix NPE in MlMemoryAutoscalingDecider * Update docs/changelog/116650.yaml * Update 116650.yaml * Update docs/changelog/116650.yaml * better fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #116384